Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to kubecost v2 #2959

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: upgrade to kubecost v2 #2959

wants to merge 2 commits into from
+848 −527

Conversation

takirala
Copy link
Contributor

@takirala takirala commented Dec 18, 2024 •
edited
Loading

What problem does this PR solve?:

Upgrade kubecost to v2.

Depends on mesosphere/charts#1529 for cosi helm chart

Depends on https://github.com/mesosphere/kommander/pull/5374 for attached clusters.

ceph cosi driver needs to be refactored

Which issue(s) does this PR fix?:

NCN-104266
NCN-104267

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@takirala
feat: add temporary helm repos
b6d2018 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@takirala
feat: upgrade to kubecost v2
6cb89a4 
Signed-off-by: Tarun Gupta Akirala <[email protected]>
@github-actions github-actions bot added services/centralized-kubecost services/kubecost size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 18, 2024
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/tga/kubecost-v2

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12402706399

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%
Totals Coverage Status
Change from base Build 12399927043: 0.0%
Covered Lines: 167
Relevant Lines: 323
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/centralized-kubecost services/kubecost size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takirala @coveralls @mesosphere-ci